fix: soft-delete via direct UPDATE + non-generator get_first #6

Merged

i.bahlai merged 1 commit from hotfix/delete-entity-commit into main

2026-04-05 12:40:44 +00:00

i.bahlai commented

2026-04-05 12:37:55 +00:00

Owner

Two fixes for the soft-delete flow (delete_entity):

get_first: replaced async-generator-based implementation with
a direct session query. The generator-based approach kept the
session open after returning the first result, causing connection
leaks that blocked subsequent writes (especially on SQLite).
soft_delete: new repo method that issues a direct
UPDATE … SET remove=true with explicit commit, avoiding the
ORM merge path on detached entities entirely.
delete_entity: now calls repo.soft_delete(entity_id) instead
of fetching, mutating a detached entity, and calling repo.update().

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Two fixes for the soft-delete flow (delete_entity): 1. **get_first**: replaced async-generator-based implementation with a direct session query. The generator-based approach kept the session open after returning the first result, causing connection leaks that blocked subsequent writes (especially on SQLite). 2. **soft_delete**: new repo method that issues a direct `UPDATE … SET remove=true` with explicit commit, avoiding the ORM merge path on detached entities entirely. 3. **delete_entity**: now calls `repo.soft_delete(entity_id)` instead of fetching, mutating a detached entity, and calling `repo.update()`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

i.bahlai added 1 commit

2026-04-05 12:37:55 +00:00

fix: soft-delete via direct UPDATE + non-generator get_first

CI Pipeline - Development / Code Quality Check (pull_request) Successful in 1m26s

Details

CI Pipeline - Development / Run Tests (pull_request) Successful in 1m49s

Details

3944c44f23

Two fixes for the soft-delete flow (delete_entity):

1. **get_first**: replaced async-generator-based implementation with
   a direct session query. The generator-based approach kept the
   session open after returning the first result, causing connection
   leaks that blocked subsequent writes (especially on SQLite).

2. **soft_delete**: new repo method that issues a direct
   `UPDATE … SET remove=true` with explicit commit, avoiding the
   ORM merge path on detached entities entirely.

3. **delete_entity**: now calls `repo.soft_delete(entity_id)` instead
   of fetching, mutating a detached entity, and calling `repo.update()`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>